Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI tests #521

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Improve CI tests #521

merged 1 commit into from
Nov 9, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 8, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used npm run format for formatting the code before submitting the pull request.

Resolve collisions and enhance test performance by implementing the following actions:

  1. Combine the Docker and Distribution tests into a single suite called "Cloud Instance Tests" to ensure there are no conflicts between them, such as:
   JFrog Artifactory Extension Tests
    1) "before all" hook in "JFrog Artifactory Extension Tests"


  0 passing (7s)
  1 failing

  1) JFrog Artifactory Extension Tests
       "before all" hook in "JFrog Artifactory Extension Tests":
     Error: Server responded to ***/artifactory/api/repositories/ado-extension-test-repo1-1730906673 with status code 400:
{
  "errors" : [ {
    "status" : 400,
    "message" : "Fail to create. Reason local repository with key: ado-extension-test-repo1-1730906673 already exist\n"
  } ]
}
  1. Configure the Docker repository names to be timestamp-dependent, similar to other package types. This reduces the risk of collisions between different CI runs.
  2. Avoid creating unnecessary repositories when certain tests are excluded.

@yahavi yahavi self-assigned this Nov 8, 2024
@yahavi yahavi added the ignore for release Automatically generated release notes label Nov 8, 2024
@yahavi yahavi requested a review from eyalbe4 November 8, 2024 15:45
@yahavi yahavi marked this pull request as ready for review November 8, 2024 15:45
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 8, 2024
@yahavi yahavi merged commit 4ad234c into jfrog:dev Nov 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants