Do not leak Finally in App to satisfy clang-tidy

jhasse · Oct 29, 2024 · 0b0c41b · 0b0c41b
1 parent 3e4523f
commit 0b0c41b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/App.cpp b/src/App.cpp
@@ -82,7 +82,7 @@ std::string App::getDisplayName() const {
 
 void App::setDisplayName(const std::string& displayName) {
 	if (!impl) { // e.g. Android when using showWindow without jnglInit
-		new Finally(init({})); // leak
+		static Finally dummy(init({}));
 	}
 	impl->displayName = displayName;
 }
@@ -105,7 +105,7 @@ void App::setPixelArt(const bool pixelArt) {
 
 void App::registerShaderProgram(ShaderProgram* shaderProgram) {
 	if (!impl) { // unit tests
-		new Finally(init({})); // leak
+		static Finally dummy(init({}));
 	}
 	impl->shaderPrograms.insert(shaderProgram);
 }

diff --git a/src/sdl/sdl.hpp b/src/sdl/sdl.hpp
@@ -26,7 +26,7 @@ class SDL {
 private:
 	SDL();
 	~SDL();
-	void setHint(const char* name, bool);
+	static void setHint(const char* name, bool);
 };
 
 } // namespace jngl