Fix crash when using FrameBuffer in Android simulator

Using GL_RGBA is incorrect for internalformat but was chosing for emscripten in f5cd8ac
jhasse · Dec 5, 2023 · 3dbe12e · 3dbe12e
1 parent 621c01e
commit 3dbe12e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/jngl/FrameBuffer.cpp b/src/jngl/FrameBuffer.cpp
@@ -61,7 +61,7 @@ FrameBuffer::FrameBuffer(const Pixels width, const Pixels height)
 
 	glGenRenderbuffers(1, &impl->buffer);
 	glBindRenderbuffer(GL_RENDERBUFFER, impl->buffer);
-	glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA, static_cast<int>(width),
+	glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, static_cast<int>(width),
 	                      static_cast<int>(height));
 
 	glGenFramebuffers(1, &impl->fbo);

diff --git a/src/opengl.hpp b/src/opengl.hpp
@@ -24,6 +24,9 @@
 			#define glGenVertexArrays glGenVertexArraysOES
 			#define glBindVertexArray glBindVertexArrayOES
 			#define glDeleteVertexArrays glDeleteVertexArraysOES
+			#if defined(__EMSCRIPTEN__)
+				#define GL_RGBA8 GL_RGBA8_OES
+			#endif
 		#else
 			#include <glad/gl.h>
 		#endif