feat(build): Checks config.js syntax. #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,7 +130,7 @@ config.enableNoisyMicDetection = {{ $ENABLE_NOISY_MIC_DETECTION }}; | |||
| // | |||
|
|
|||
| config.p2p = { | |||
| enabled: {{ $ENABLE_P2P }}, | |||
| enabled: {{ $ENABLE_P2P }}; | |||
There was a problem hiding this comment.
Don't you have to revert this?
There was a problem hiding this comment.
I suppose he is testing the CI works.
There was a problem hiding this comment.
yep the commit message is drop: :)
damencho
force-pushed
the
gh-check-syntax
branch
from
74debc3 to
b1b0017
Compare
damencho
force-pushed
the
gh-check-syntax
branch
from
b1b0017 to
37283de
Compare
|
Dropping the broken commit now :) |
damencho
force-pushed
the
gh-check-syntax
branch
from
37283de to
2580140
Compare
Co-authored-by: Aaron van Meerten <[email protected]>
Co-authored-by: Aaron van Meerten <[email protected]>
|
Hum ... I will need to merge both files :) |
* Update ci.yml * Update ci.yml
aaronkvanmeerten
approved these changes
Dec 13, 2024
saghul
added a commit
that referenced
this pull request
Dec 17, 2024
* 9098202 feat(lint): add tpl lint step for each project (#1983) * 70b75f5 feat(build): Checks config.js syntax. (#1981) * f18b182 fix(web): config.js syntax errors (#1980) * eea18b1 feat: Add an option to enable VLA. (#1979) * 9527545 feat(web) Add defaults and env variables for codec preference. (#1978) * 6ae3414 feat(prosody): Sets recorder prefixes. * 07ea79a feat(prosody): Enables connection resumption for jicofo and jvb. * 5341065 Update docker-compose.yml (#1968) * 5e8b702 fix(prosody-visitors): proper variable for transcriber jid in rate limit (#1967) * d3db3a5 fix(jibri,jicofo,jigasi,prosody,web): respect previous XMPP_RECORDER_DOMAIN value if set (#1966) * 2d9c3cc feat(web): allow comment at the top of config.js to be overridden (#1964) * 9fe5b8b fix(web) Remove no longer used config setting. Av1 has already been enabled by default. * a53775c misc: working on unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.