fix(whisper): Fixes leaking whisper connections. #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves setting transcriber room name earlier, so we can use it in creating the transcriber sessions. When a participant never talked, is missing in one of the participants lists and those got desync and we never remove the websocket from the pool, which results in reusing it for the same room (the socket has timeouted and disconnected) and there is a NPE that prevents transcriptions in the meeting. 2023-11-30 13:09:17.645 SEVERE: [188854] org.jivesoftware.smack.AbstractXMPPConnection.lambda$invokeStanzaCollectorsAndNotifyRecvListeners$8: Exception in packet listener java.lang.NullPointerException at org.jitsi.jigasi.transcription.WhisperWebsocket.addParticipantIfNotExists(WhisperWebsocket.java:362) at org.jitsi.jigasi.transcription.WhisperWebsocket.addListener(WhisperWebsocket.java:373) at org.jitsi.jigasi.transcription.WhisperTranscriptionService$WhisperWebsocketStreamingSession.addTranscriptionListener(WhisperTranscriptionService.java:170) at org.jitsi.jigasi.transcription.Participant.joined(Participant.java:524)
aaronkvanmeerten
approved these changes
Dec 1, 2023
rpurdel
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.