fix: transcriber settings precedence #518
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
============================================
- Coverage 20.86% 20.84% -0.02%
Complexity 289 289
============================================
Files 74 74
Lines 6222 6240 +18
Branches 833 833
============================================
+ Hits 1298 1301 +3
- Misses 4699 4718 +19
+ Partials 225 221 -4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| { | ||
| logger.debug("Using " + transcriberClass + " as the transcriber class."); | ||
| } | ||
| logger.info("Using " + transcriberClass + " as the transcriber class."); |
There was a problem hiding this comment.
Yeah, is this duplicated with the print bellow.
| .getString( | ||
| CUSTOM_TRANSCRIPTION_SERVICE_PROP, | ||
| null); | ||
| if (customTranscriptionServiceClass != null) | ||
| { | ||
| logger.info("Using " + customTranscriptionServiceClass + " as the transcriber class."); |
There was a problem hiding this comment.
Maybe leave only the print if there is a tenant enabling non default transcription.
And please add the callContext to the log as the rest of the code.
| } | ||
| else | ||
| { | ||
| logger.info("No custom transcriber class found, falling back to default."); |
No description provided.