Transcribing backend flag #519
Conversation
When backend enabled, even if no one is listening for transcriptions we keep going.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
============================================
- Coverage 20.86% 20.85% -0.02%
- Complexity 289 291 +2
============================================
Files 74 74
Lines 6222 6278 +56
Branches 833 837 +4
============================================
+ Hits 1298 1309 +11
- Misses 4699 4749 +50
+ Partials 225 220 -5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| String avModerationAddress = avIdentity.getName(); | ||
| this.getAudioModeration().setAvModerationAddress(avModerationAddress); | ||
|
|
||
| logger.info(String.format("%s Discovered %s for %oms.", |
There was a problem hiding this comment.
Do we really care about this message only for avModarationAddress? I suggest either remove it or move it out of the "if" to be printed right after the discoverInfo call
There was a problem hiding this comment.
I'll remove that and move the print after, I just kept it when moving the stuff.
| // we process room metadata messages only when we are transcribing | ||
| if (roomMetadataIdentity != null && this.gatewaySession instanceof TranscriptionGatewaySession) | ||
| { | ||
| if (roomMetadataListener != null) |
There was a problem hiding this comment.
Any reason not to make the field final and always initialize it? You can remove these 5 lines of code and not worry about this executing after a re-connect for example
| private void maybeStopTranscription() | ||
| { | ||
| if (transcriber.isTranscribing() | ||
| && !(transcriber.isAnyParticipantRequestingTranscription() |
There was a problem hiding this comment.
nit: suggest to extract a isTranscriptionRequested() method
No description provided.