feat(rn) start listening for stats on the Thumbnail #10583
+126
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Dec 10, 2021
react/features/video-menu/components/native/ConnectionStatusComponent.js
Show resolved
Hide resolved
react/features/video-menu/components/native/ConnectionStatusComponent.js
Outdated
Show resolved
Hide resolved
tmoldovan8x8
force-pushed
the
task/listen-for-rtc-stats-on-thumbnail
branch
from
0a6953b to
0698107
Compare
tmoldovan8x8
force-pushed
the
task/listen-for-rtc-stats-on-thumbnail
branch
from
0698107 to
af39a84
Compare
tmoldovan8x8
force-pushed
the
task/listen-for-rtc-stats-on-thumbnail
branch
from
af39a84 to
cfc4efb
Compare
|
I gave this a quick test and I don't see stats for the local participant (simulator, but I should see them I believe) and for the remote, once I get them all, if I close and open the menu half of them go N/A and they come back after a bit. Can you PTAL? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Calinteodor Let's try to push this over the finish line when time allows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.