Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hand-recognition) #15001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(hand-recognition) #15001

wants to merge 1 commit into from
+148 −33

Conversation

liumengyuan1997
Copy link
Contributor

Hi reviewer,

This is a GSoC task. I added a hand recognition feature by using the Human repository. We should also 'handtrack.json', and 'handlandmark-lite.json' files to the libs folder to use it. Feel free to let me know which part is inappropriate.

Thanks,
Mengyuan

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul
saghul requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Any chance you could upload a video showing it in action?

react/features/face-landmarks/FaceLandmarksDetector.ts Outdated Show resolved Hide resolved
react/features/face-landmarks/FaceLandmarksDetector.ts Outdated Show resolved Hide resolved
react/features/face-landmarks/FaceLandmarksHelper.ts Outdated Show resolved Hide resolved
react/features/face-landmarks/FaceLandmarksHelper.ts Outdated Show resolved Hide resolved
react/features/face-landmarks/FaceLandmarksHelper.ts Outdated Show resolved Hide resolved
config.js Show resolved Hide resolved
@liumengyuan1997 liumengyuan1997 force-pushed the gesture-recognition branch 2 times, most recently from 4a4158b to 717c17a Compare August 21, 2024 08:03
@liumengyuan1997 liumengyuan1997 force-pushed the gesture-recognition branch 2 times, most recently from f1755a2 to 3b63cc7 Compare August 23, 2024 03:58
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 22, 2024
pullrequest[bot]
pullrequest bot reviewed Nov 22, 2024
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard

@saghul
Copy link
Member

saghul commented Nov 22, 2024

@mihhu shall we land this?

@github-actions github-actions bot removed the stale label Nov 23, 2024
@tuhinmallick
Copy link

Any update about this feature ? Zoom has this feature now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@saghul saghul saghul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liumengyuan1997 @jitsi-jenkins @saghul @tuhinmallick