Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fake ice credentials during first ICE restart #1749

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use fake ice credentials during first ICE restart #1749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
315048f
use fake ICE credentials for first restart
nils-ohlmeier Oct 7, 2021
613f6e8
use fake ICE credentials for first restart
nils-ohlmeier Oct 7, 2021
37b63b4
Merge branch 'fake_ice_credentials' of github.com:nils-ohlmeier/lib-j…
nils-ohlmeier Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/xmpp/JingleSessionPC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,13 @@ export default class JingleSessionPC extends JingleSession {
newFingerprint.attr('hash', 'sha-1');
newFingerprint.text('00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00');

// To avoid the DTLS handshake with the above fake certificate value to succeed and then getting rejected
// by the endpoint, we provide fake ICE credentials as well to get into an ICE failure instead.
const newIceCredentials = jingleOfferElem.find('>content>transport');

newIceCredentials.attr('ufrag', 'fakeufrag');
newIceCredentials.attr('pwd', 'thisfakepwdneedstobe22charslong');

// First set an offer with a rejected 'data' section
this.setOfferAnswerCycle(
jingleOfferElem,
Expand Down