feat(ScreenObtainer): add more control over screen obtainer #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
saghul
reviewed
Oct 10, 2023
modules/RTC/ScreenObtainer.js
Outdated
| @@ -212,13 +237,19 @@ const ScreenObtainer = { | |||
| } | |||
| } | |||
|
|
|||
| // Allow a user to be shown a preference for what screen is to be captured. | |||
| if (browser.isSafari() && browser.isEngineVersionGreaterThan(11) && desktopDisplaySurface) { | |||
There was a problem hiding this comment.
We don't support Safari < 13 so you can skip the version check.
There was a problem hiding this comment.
Thank you! Updated to remove that
|
Thanks for the PR @DanielMcAssey! The PR LGTM. It would be nice to bunch all these options together under |
|
Hey @jallamsetty1, thanks for the feedback. I have just updated it to put all the new settings under screenShareSettings |
|
Jenkins test this please. |
jallamsetty1
approved these changes
Oct 23, 2023
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
* feat(ScreenObtainer): add more control over screen obtainer * fix(ScreenObtainer): fix constraints to select a preferential display surface * fix(ScreenObtainer): remove Safari version check for displaySurface * fix(ScreenObtainer): move all settings under screenShareSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented these changes on our application, to allow for additional control of the screen obtainer on the browser.
It may not apply to Jitsi, however I thought I would propose these changes for more control over the library.