Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SS): Reverse the encoding order for Firefox desktop streams. #2384

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix(SS): Reverse the encoding order for Firefox desktop streams. #2384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/RTC/TPCUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ export class TPCUtils {
// The SSRCs on older versions of Firefox are reversed in SDP, i.e., they have resolution order of 1:2:4 as
// opposed to Chromium and other browsers. This has been reverted in Firefox 117 as part of the below commit.
// https://hg.mozilla.org/mozilla-central/rev/b0348f1f8d7197fb87158ba74542d28d46133997
const reversedEncodings = browser.isFirefox() && browser.isVersionLessThan(117);
// This revert seems to be applied only to camera tracks, the desktop stream encodings still have the
// resolution order of 4:2:1.
const reversedEncodings = browser.isFirefox()
&& (videoType === VideoType.DESKTOP || browser.isVersionLessThan(117));

return [
{
Expand Down