fix(GlobalOnErrorHandler) avoid calling it when we handle the error #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should never be needed if the error is handled, and if it isn't, it will bubble up and end up in the handler anyway due to window.onerror.
All modern browsers implement window.addEventListener for the 'error' and 'unhandledrejection' listeners. Thus there is zero benefit from using the legacy `onerror` handler here and rolling multiple handlers ourselves. There is an old config option `enableWindowOnErrorHandler` which was never whitelisted in Jitsi Meet, so I'm 100% sure nobody is using it. Even if someone was, migrarting to the above is simply better in every possible way.
saghul
force-pushed
the
rm-globalonerrorhandler
branch
from
2f0226c to
5205785
Compare
saghul
added a commit
to saghul/jitsi-meet
that referenced
this pull request
Dec 14, 2023
…nt handling Conceptually related: jitsi/lib-jitsi-meet#2411
hristoterezov
approved these changes
Dec 14, 2023
saghul
added a commit
to jitsi/jitsi-meet
that referenced
this pull request
Dec 15, 2023
…nt handling Conceptually related: jitsi/lib-jitsi-meet#2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.