fix(chat-features): Add messageId and change id to participantId #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
he-patrick
commented
Jul 29, 2024
•
he-patrick
commented
- messageId needs to be added to be able to attach reactions to specific messages
- participantId indicates that it is the participant's id rather than the message's id
|
Hi, thanks for your contribution! |
saghul
reviewed
Jul 29, 2024
| // we will fire explicitly that this is a guest(isGuest:true) to the conference | ||
| // informing that this is probably a message from a guest to the conference (visitor) | ||
| // a message with explicit name set | ||
| this.eventEmitter.emit(XMPPEvents.MESSAGE_RECEIVED, | ||
| from, txt, this.myroomjid, stamp, nick, Boolean(nick)); | ||
| from, txt, this.myroomjid, stamp, nick, Boolean(nick), messageId); |
There was a problem hiding this comment.
Can you add it above too, for private messages?
According to RFC: it is possible that there is no id, is that a problem? |
|
Ugh, good point! How about we generate an uuid v4 in that case? |
|
I added the uuid v4 generation on JM. |
Add it here please, so the applications don't need to worry about that and can assume it's there. |
|
Code looks good but you need to fix the import order. Run "npm run lint" to see exactly what's wrong, or check the CI step output. |
damencho
approved these changes
Jul 31, 2024
|
jenkins test this please |
|
Looks like there are some typing errors you need to tackle in the JM PR: |
|
For the parameters, lint says to put them in ascending order. Should I do that or did we want to keep the custom order? And if so do I add 
|
You can sort them since they are really an object, not plain parameters where the order matters. |
|
Jenkins please test this please. |
|
Unrelated test failure, landing. |
saghul
approved these changes
Aug 6, 2024
|
Great work @he-patrick ! 🚀 |
|
It may be related, as the error is in IFrameAPICommandsTest. testCommandSendChatMessage ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.