fix(browser) detect WebRTC APIs and mark browser unsupported if not #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some so called "security" browser extensions override WebRTC APIs so even if the UA string suggests the browser is supported, it won't work. Coincidentally, this should also mark Safari in Lockdown Mode as unsupported, since the WebRTC APIs are not available in that case.
saghul
force-pushed
the
unsupported-webrtc-apis
branch
from
10cf346 to
b8b55a5
Compare
jallamsetty1
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some so called "security" browser extensions override WebRTC APIs so even if the UA string suggests the browser is supported, it won't work.
Coincidentally, this should also mark Safari in Lockdown Mode as unsupported, since the WebRTC APIs are not available in that case.