Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazon-eks-pod-identity-webhook): allow a set of configuration fields to be templated #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(amazon-eks-pod-identity-webhook): allow a set of configuration fields to be templated #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e454637
feat(amazon-eks-pod-identity-webhook): allow a set of configuration f…
tiagoposse Dec 17, 2024
4f25e6a
chore(amazon-eks-pod-identity-webhook): bump chart version
tiagoposse Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/amazon-eks-pod-identity-webhook/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: amazon-eks-pod-identity-webhook
description: A Kubernetes webhook for pods that need AWS IAM access
version: 2.3.0
version: 2.4.0
type: application
# renovate: image=amazon/amazon-eks-pod-identity-webhook
appVersion: "v0.6.1"
Expand Down
2 changes: 1 addition & 1 deletion charts/amazon-eks-pod-identity-webhook/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# amazon-eks-pod-identity-webhook

![Version: 2.2.0](https://img.shields.io/badge/Version-2.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.5.7](https://img.shields.io/badge/AppVersion-v0.5.7-informational?style=flat-square)
![Version: 2.4.0](https://img.shields.io/badge/Version-2.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.6.1](https://img.shields.io/badge/AppVersion-v0.6.1-informational?style=flat-square)

A Kubernetes webhook for pods that need AWS IAM access

Expand Down
2 changes: 1 addition & 1 deletion charts/amazon-eks-pod-identity-webhook/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ metadata:
labels:
{{- include "amazon-eks-pod-identity-webhook.labels" . | nindent 4 }}
data:
config: {{ .Values.config.podIdentityWebhookMap.data | toJson | quote }}
config: {{ .Values.config.podIdentityWebhookMap.data | toJson | tpl . | quote }}
{{- end }}
8 changes: 4 additions & 4 deletions charts/amazon-eks-pod-identity-webhook/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ spec:
imagePullPolicy: {{ .Values.image.pullPolicy }}
command:
- /webhook
- --annotation-prefix={{ .Values.config.annotationPrefix }}
- --aws-default-region={{ .Values.config.defaultAwsRegion }}
- --annotation-prefix={{ tpl .Values.config.annotationPrefix . }}
- --aws-default-region={{ tpl .Values.config.defaultAwsRegion . }}
- --in-cluster=false
- --logtostderr
- --namespace={{ include "amazon-eks-pod-identity-webhook.namespace" . }}
- --metrics-port={{ .Values.config.ports.metrics }}
- --port={{ .Values.config.ports.webhook }}
- --sts-regional-endpoint={{ .Values.config.stsRegionalEndpoint }}
- --token-audience={{ .Values.config.tokenAudience }}
- --sts-regional-endpoint={{ tpl .Values.config.stsRegionalEndpoint . }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at CI, stsRegionalEndpoint is a bool, but needs a string.

I guess {{ print .Values.config.stsRegionalEndpoint }} should help here.

- --token-audience={{ tpl .Values.config.tokenAudience . }}
- --token-expiration={{ .Values.config.tokenExpiration }}
- --token-mount-path={{ .Values.config.tokenMountPath }}
- --tls-cert=/etc/webhook/certs/tls.crt
Expand Down
Loading