Pass on encoding knowledge in HTTP layer to Beautiful Soup #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests's response.encoding has a encoding extracted from the Content-Type HTTP header. Passing the encoding to the Beautiful Soup will improve encoding detection in the Beautiful Soup even when the chardet package is not installed. The Beautiful Soup can try the encoding at first, then try an encoding extracted from the HTML content.
Note that response.encoding is None when encoding is not specified in the Content-Type header. In that case, behavior of Beautiful Soup does not change.
Before
Beautiful Soup failed to detect an encoding; Mojibake is occurred.
Note that www.google.co.jp put an encoding in the HTTP Content-Type header, but its HTML content does not contain an encoding such as
<meta charset="...">
.After
The correct encoding is detected.
Environment