Skip to content

Commit

Permalink
Added pull request Freeboard#217
Browse files Browse the repository at this point in the history
  • Loading branch information
joed74 committed Aug 20, 2022
1 parent 1ef6ccc commit d952def
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 4 deletions.
5 changes: 4 additions & 1 deletion js/freeboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,6 @@ function PaneModel(theFreeboardModel, widgetPlugins) {

this.processSizeChange = function()
{
console.log("processSizeChange");
// Give the animation a moment to complete. Really hacky.
// TODO: Make less hacky. Also, doesn't work when screen resizes.
setTimeout(function(){
Expand Down Expand Up @@ -1660,6 +1659,10 @@ PluginEditor = function(jsEditor, valueEditor)
{
newSettings.settings[settingDef.name] = Number($(this).val());
}
else if (settingDef.type == "integer")
{
newSettings.settings[settingDef.name] = parseInt($(this).val());
}
else
{
newSettings.settings[settingDef.name] = $(this).val();
Expand Down
2 changes: 1 addition & 1 deletion js/freeboard.min.js

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion js/freeboard_plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,6 @@ function PaneModel(theFreeboardModel, widgetPlugins) {

this.processSizeChange = function()
{
console.log("processSizeChange");
// Give the animation a moment to complete. Really hacky.
// TODO: Make less hacky. Also, doesn't work when screen resizes.
setTimeout(function(){
Expand Down Expand Up @@ -1660,6 +1659,10 @@ PluginEditor = function(jsEditor, valueEditor)
{
newSettings.settings[settingDef.name] = Number($(this).val());
}
else if (settingDef.type == "integer")
{
newSettings.settings[settingDef.name] = parseInt($(this).val());
}
else
{
newSettings.settings[settingDef.name] = $(this).val();
Expand Down
2 changes: 1 addition & 1 deletion js/freeboard_plugins.min.js

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions lib/js/freeboard/PluginEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ PluginEditor = function(jsEditor, valueEditor)
{
newSettings.settings[settingDef.name] = Number($(this).val());
}
else if (settingDef.type == "integer")
{
newSettings.settings[settingDef.name] = parseInt($(this).val());
}
else
{
newSettings.settings[settingDef.name] = $(this).val();
Expand Down

0 comments on commit d952def

Please sign in to comment.