Add Library to proto definition #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
Dec 27, 2024
| message Version { | ||
| int32 major = 1; | ||
| int32 minor = 2; | ||
| int32 patch = 3; |
| // Message representing a Descriptor for versioning and identification | ||
| message LibDescriptor { | ||
| Version version = 1; // Semantic versioning information | ||
| int32 depth = 2; // Depth in the dependency graph |
There was a problem hiding this comment.
Move this to top level. No need to copy this data in every descriptor.
| message LibDescriptor { | ||
| Version version = 1; // Semantic versioning information | ||
| int32 depth = 2; // Depth in the dependency graph | ||
| string vcs_indent = 3; // Version control system identifier (e.g., git:commit:aae) |
There was a problem hiding this comment.
Same note about moving to top level.
|
|
||
| // Message representing a Library | ||
| message Library { | ||
| string name = 1; |
There was a problem hiding this comment.
Should add uri to main repo.
| message LibHistory { | ||
| LibDescriptor previous_patch = 1; // Descriptor for the previous patch version, if any | ||
| LibDescriptor previous_minor = 2; // Descriptor for the previous minor version, if any | ||
| LibDescriptor previous_major = 3; // Descriptor for the previous major version, if any |
There was a problem hiding this comment.
Include previous_prerelease
| LibDescriptor previous_patch = 1; // Descriptor for the previous patch version, if any | ||
| LibDescriptor previous_minor = 2; // Descriptor for the previous minor version, if any | ||
| LibDescriptor previous_major = 3; // Descriptor for the previous major version, if any | ||
| } |
There was a problem hiding this comment.
Add other_previous which is a repeated random link uniform on rwith distance proportional to 2^r (to make it navigable quickly) (maybe around log depth previous links).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1152