Remove resetDatabase trait from tests

jolicode · Sep 30, 2021 · 97d256b · 97d256b
1 parent fcf1555
commit 97d256b
Show file tree

Hide file tree

Showing 10 changed files with 168 additions and 122 deletions.
diff --git a/config/packages/security.yaml b/config/packages/security.yaml
@@ -2,6 +2,9 @@ security:
     password_hashers:
         App\Entity\User:
             algorithm: native
+    encoders:
+        App\Entity\User:
+            algorithm: native
     providers:
         user:
             entity:

diff --git a/config/packages/test/security.yaml b/config/packages/test/security.yaml
@@ -1,4 +1,10 @@
 security:
+    encoders:
+        App\Entity\User:
+            algorithm: native
+            cost: 4
+            time_cost: 3
+            memory_cost: 10
     password_hashers:
         App\Entity\User:
             algorithm: native

diff --git a/tasks.py b/tasks.py
@@ -153,6 +153,7 @@ def tests(c):
     Launch unit and functional tests
     """
     with Builder(c):
+        reset(c)
         docker_compose_run(c, 'php ./vendor/bin/simple-phpunit')
 
 

diff --git a/tests/Controller/UserAccount/AbstractBaseFactories.php b/tests/Controller/UserAccount/AbstractBaseFactories.php
@@ -0,0 +1,89 @@
+<?php
+
+/*
+ * This file is part of the Starfleet Project.
+ *
+ * (c) Starfleet <[email protected]>
+ *
+ * For the full copyright and license information,
+ * please view the LICENSE file that was distributed with this source code.
+ */
+
+namespace App\Tests\Controller\UserAccount;
+
+use App\Entity\User;
+use App\Factory\UserFactory;
+use Doctrine\Common\DataFixtures\Purger\ORMPurger;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Zenstruck\Foundry\Test\Factories;
+
+abstract class AbstractBaseFactories extends WebTestCase
+{
+    use Factories;
+
+    private ?KernelBrowser $client = null;
+
+    protected function setUp(): void
+    {
+        $purger = new ORMPurger($this->getEntityManager());
+        $purger->purge();
+        $this->generateData();
+    }
+
+    protected function getClient(?User $user = null)
+    {
+        if (!$this->client) {
+            $user = $user ?: $this->getTestUser();
+            $this->ensureKernelShutdown();
+            $this->client = $this->createClient();
+            $this->client->followRedirects();
+            $this->client->loginUser($user);
+        }
+
+        return $this->client;
+    }
+
+    protected function getTestUser()
+    {
+        $user = UserFactory::repository()->findOneBy([
+            'email' => '[email protected]',
+        ]);
+
+        if (!$user) {
+            $user = UserFactory::createOne([
+                'name' => 'Starfleet User',
+                'email' => '[email protected]',
+                'password' => 'password',
+            ]);
+        }
+
+        $user = $user->object();
+
+        return $user;
+    }
+
+    protected function getAdminUser()
+    {
+        $user = $this->getTestUser()
+            ->addRole('ROLE_ADMIN')
+            ->setName('Starfleet Admin')
+            ->setEmail('[email protected]')
+            ->setPassword('password')
+        ;
+
+        $this->getEntityManager()->flush();
+
+        return $user;
+    }
+
+    /**
+     * This method must create all the entities your test will need.
+     */
+    abstract protected function generateData();
+
+    private function getEntityManager()
+    {
+        return $this->getContainer()->get('doctrine')->getManager();
+    }
+}
diff --git a/tests/Controller/UserAccount/BaseFactories.php b/tests/Controller/UserAccount/BaseFactories.php
diff --git a/tests/Controller/UserAccount/FutureConferencesControllerTest.php b/tests/Controller/UserAccount/FutureConferencesControllerTest.php
@@ -13,7 +13,10 @@
 
 use App\Factory\ConferenceFactory;
 
-class FutureConferencesControllerTest extends BaseFactories
+/**
+ * @group user_account
+ */
+class FutureConferencesControllerTest extends AbstractBaseFactories
 {
     private string $conferencesUrl = '/user/future-conferences';
 
@@ -25,31 +28,22 @@ public function testFutureConferencesPageLoad()
 
     public function testConferencesAreDisplayed()
     {
-        ConferenceFactory::createMany(3, [
+        $crawler = $this->getClient()->request('GET', $this->conferencesUrl);
+
+        $featuredConferencesCount = \count(ConferenceFactory::findBy([
             'featured' => true,
-            'startAt' => new \DateTime('+2 days'),
-            'endAt' => new \DateTime('+5 days'),
-        ]);
+        ]));
 
-        ConferenceFactory::createMany(5, [
+        $regularConferencesCount = \count(ConferenceFactory::findBy([
             'featured' => false,
-            'startAt' => new \DateTime('+2 days'),
-            'endAt' => new \DateTime('+5 days'),
-        ]);
+        ]));
 
-        $crawler = $this->getClient()->request('GET', $this->conferencesUrl);
-
-        self::assertCount(3, $crawler->filter('div#featured-conferences-block div.conference-card'));
-        self::assertCount(5, $crawler->filter('div#regular-conferences-block div.conference-card'));
+        self::assertCount($featuredConferencesCount, $crawler->filter('div#featured-conferences-block div.conference-card'));
+        self::assertCount($regularConferencesCount, $crawler->filter('div#regular-conferences-block div.conference-card'));
     }
 
     public function testAskParticipationWork()
     {
-        ConferenceFactory::createOne([
-            'startAt' => new \DateTime('+2 days'),
-            'endAt' => new \DateTime('+5 days'),
-        ]);
-
         $this->getClient()->request('GET', $this->conferencesUrl);
         $this->getClient()->submitForm('Ask Participation');
 
@@ -58,15 +52,24 @@ public function testAskParticipationWork()
 
     public function testSubmitTalkWork()
     {
-        ConferenceFactory::createOne([
-            'startAt' => new \DateTime('+2 days'),
-            'endAt' => new \DateTime('+5 days'),
-            'cfpEndAt' => new \DateTime('+5 days'),
-        ]);
-
         $this->getClient()->request('GET', $this->conferencesUrl);
         $this->getClient()->submitForm('Submit a Talk');
 
         self::assertResponseIsSuccessful();
     }
+
+    protected function generateData()
+    {
+        ConferenceFactory::createMany(3, [
+            'featured' => true,
+            'startAt' => new \DateTime('+1 days'),
+            'endAt' => new \DateTime('+1 days'),
+        ]);
+
+        ConferenceFactory::createMany(3, [
+            'featured' => false,
+            'startAt' => new \DateTime('+1 days'),
+            'endAt' => new \DateTime('+1 days'),
+        ]);
+    }
 }
diff --git a/tests/Controller/UserAccount/HomepageControllerTest.php b/tests/Controller/UserAccount/HomepageControllerTest.php
@@ -11,7 +11,10 @@
 
 namespace App\Tests\Controller\UserAccount;
 
-class HomepageControllerTest extends BaseFactories
+/**
+ * @group user_account
+ */
+class HomepageControllerTest extends AbstractBaseFactories
 {
     public function testUserPageForUsers()
     {
@@ -25,10 +28,15 @@ public function testUserPageForUsers()
     public function testUserPageForAdmins()
     {
         $user = $this->getAdminUser();
-        $crawler = $this->getClient()->request('GET', '/user/account');
+        $crawler = $this->getClient($user)->request('GET', '/user/account');
 
         self::assertResponseIsSuccessful();
         self::assertSelectorTextContains('.username', $user->getName());
         self::assertCount(1, $crawler->filter('#admin-button'));
     }
+
+    protected function generateData()
+    {
+        // No specific data needed for these tests
+    }
 }
diff --git a/tests/Controller/UserAccount/ParticipationControllerTest.php b/tests/Controller/UserAccount/ParticipationControllerTest.php
@@ -19,7 +19,10 @@
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Component\DomCrawler\Crawler;
 
-class ParticipationControllerTest extends BaseFactories
+/**
+ * @group user_account
+ */
+class ParticipationControllerTest extends AbstractBaseFactories
 {
     /** @dataProvider provideRoutes */
     public function testAllPagesLoad(string $route)
@@ -31,8 +34,6 @@ public function testAllPagesLoad(string $route)
 
     public function testParticipationsPageWork()
     {
-        $this->createTestData();
-
         $crawler = $this->getClient()->request('GET', '/user/participations');
 
         self::assertCount(2, $crawler->filter('#pending-participations-block .card'));
@@ -50,6 +51,7 @@ public function testParticipationsFormWork()
             'startAt' => new \DateTime('+10 days'),
             'endAt' => new \DateTime('+12 days'),
         ]);
+        $preSubmitCount = \count(ParticipationFactory::all());
 
         $this->getClient()->request('GET', '/user/participations');
         $this->getClient()->submitForm('submit_participation', [
@@ -59,8 +61,10 @@ public function testParticipationsFormWork()
             'participation[conferenceTicketStatus]' => Participation::STATUS_NOT_NEEDED,
         ]);
 
-        self::assertCount(1, ParticipationFactory::all());
-        self::assertSame($this->getTestUser(), ParticipationFactory::find(1)->getParticipant());
+        $allParticipations = ParticipationFactory::all();
+
+        self::assertCount($preSubmitCount + 1, $allParticipations);
+        self::assertSame($this->getTestUser(), $allParticipations[$preSubmitCount]->getParticipant());
     }
 
     public function testEditParticipationPageWork()
@@ -94,8 +98,6 @@ public function testEditParticipationPageWork()
     /** @dataProvider provideActionRoutes */
     public function testAllEditParticipationLinksWork(string $route)
     {
-        $this->createTestData();
-
         $this->getClient()->request('GET', $route);
         $this->getClient()->submitForm('Edit Participation');
 
@@ -105,7 +107,6 @@ public function testAllEditParticipationLinksWork(string $route)
     /** @dataProvider provideActionRoutes */
     public function testAllCancelParticipationLinksWork(string $route)
     {
-        $this->createTestData();
         $crawler = $this->getClient()->request('GET', $route);
 
         if ('/user/participations' === $route) {
@@ -173,7 +174,7 @@ public function testParticipationCancelCsrfProtection()
 
     private function mainPageCancelLink(KernelBrowser $client, Crawler $crawler)
     {
-        $participationRepository = static::$container->get(ParticipationRepository::class);
+        $participationRepository = $this->getContainer()->get(ParticipationRepository::class);
         $participations = $participationRepository->findPendingParticipationsByUser($this->getTestUser());
         $preCancelCount = \count($participations);
 
@@ -187,7 +188,7 @@ private function mainPageCancelLink(KernelBrowser $client, Crawler $crawler)
         self::assertCount(--$preCancelCount, $participationRepository->findPendingParticipationsByUser($this->getTestUser()));
     }
 
-    private function createTestData()
+    protected function generateData()
     {
         ParticipationFactory::createMany(2, [
             'participant' => $this->getTestUser(),