[MRG] Add Min/Max Frequency and Add Visual Updates Ahead of 0.4 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min/max spectral frequency
|
Note that the min/max spectral freq widgets are just placeholders here, they don't actually update the defaults like the Smoothing field does. But could add that to this or another PR |
dylansdaniels
changed the title
asoplata
reviewed
Nov 26, 2024
hnn_core/tests/test_gui.py
Outdated
Comment on lines
1194
to
1195
| assert gui_min == viz_min == 10 | ||
| assert gui_max == viz_max == 100 |
There was a problem hiding this comment.
Everything looks great, the only thing I would change is removing the current default frequency values here. I think it's enough to check that they're consistent. We may want to change the default frequency values in the future, but with this check, we would also have to remember to manually change these lines in the tests.
asoplata
requested changes
Nov 26, 2024
|
@asoplata made your change and similarly edited the initial equivalency check for test_default_smoothing! |
asoplata
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding sections to Simulation tab, separating our the default values for visualization parameters that will be updated on 'run'
Improvements to network connectivity tab, adjusting spacing of Vboxes, text indentation, adding css classes to more easily target sections, updating display of the receptor names
