Update Songbird to v0.4.0 and serenity to v0.12.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed anymore after the latest songbird v4.0.0 release.
This brings major changes to audio processiond and the public serentiy API. Therefore the app is refactored to adjust to the new API.
jontze
added
dependencies
jontze
force-pushed
the
fix/update-songbird-serenity
branch
from
ba6be41 to
285aded
Compare
jontze
force-pushed
the
fix/update-songbird-serenity
branch
from
285aded to
e70e482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Songbird and serenity. As the new versions bring a lot of change to the public API, this ended in a larger refactor.
Especially the songbird update brings some good performance improvements to the audio processing as now Symphonia is used and we can finally get rid of ffmpeg as dependency.
Close #133
Close #132
Close #131
Due to the lockfile update
Close #114
Close #122
Read more about the changes with the new versions: