Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ remove broken mdformat-pyproject #262

Merged
merged 15 commits into from
Dec 9, 2024
Merged

➖ remove broken mdformat-pyproject #262

merged 15 commits into from
Dec 9, 2024

Conversation

miloth
Copy link
Contributor

@miloth miloth commented Dec 5, 2024 •
edited
Loading

  • Moved config to .mdformat.toml and removed mdformat-pyproject as the latter does not support all of the config. Solves 🐛 mdformat-pyproject not running properly #261.
  • Simplified poe command now that the config works.
  • Explicitly stating that the dev environment should use Python 3.13, required by mdformat's exclude config.

jorenham
jorenham reviewed Dec 5, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@jorenham
Copy link
Owner

jorenham commented Dec 5, 2024

closely related to csala/mdformat-pyproject#4

@jorenham
Copy link
Owner

jorenham commented Dec 7, 2024

Since it looks like mkdformat-pyproject isn't functional at the moment, I think that dropping it is indeed the best opption for now.

Could you rebase, so I can merge?

@jorenham jorenham added meta: CI Continuous integration status: needs rebase labels Dec 7, 2024
@jorenham jorenham added this to the 1.14.1.6 milestone Dec 7, 2024
jorenham
jorenham reviewed Dec 7, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@miloth miloth requested a review from jorenham December 8, 2024 10:22
jorenham
jorenham reviewed Dec 8, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
jorenham
jorenham reviewed Dec 8, 2024
View reviewed changes
.mdformat.toml Outdated Show resolved Hide resolved
@miloth miloth requested a review from jorenham December 9, 2024 12:18
jorenham
jorenham reviewed Dec 9, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@jorenham
Copy link
Owner

jorenham commented Dec 9, 2024

should be good to merge after the typo is fixed :)

@jorenham jorenham added the meta: DX Developer experience label Dec 9, 2024
@jorenham jorenham linked an issue Dec 9, 2024 that may be closed by this pull request
🐛 mdformat-pyproject not running properly #261
Closed
@jorenham jorenham changed the title mdformat debug ➖ remove broken mdformat-pyproject Dec 9, 2024
@jorenham jorenham merged commit 073d9ac into jorenham:master Dec 9, 2024
4 checks passed
@jorenham
Copy link
Owner

jorenham commented Dec 9, 2024

Thanks @miloth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
meta: CI Continuous integration meta: DX Developer experience
Projects
None yet
Milestone
1.14.1.6
Development

Successfully merging this pull request may close these issues.

🐛 mdformat-pyproject not running properly
2 participants
@miloth @jorenham