Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework docs #1172

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Rework docs #1172

merged 3 commits into from
Mar 16, 2023

Conversation

vlad-ivanov-name
Copy link
Collaborator

  • mention josh-project.dev
  • move container options to the guide
  • reword a few things

LMG
LMG reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@LMG LMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good already, I'd be okay merging it if you want.

README.md
@@ -1,25 +1,29 @@
![Just One Single History](/splash.png)

Combine the advantages of a monorepo with those of multirepo setups by leveraging a
blazingly-fast, incremental, and reversible implementation of git history filtering.
fast, incremental, and reversible implementation of git history filtering.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? It is just marketing after all, but josh is much faster than the alternatives

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: #1175

README.md

## Use cases

### Partial cloning
### Partial cloning <a href="https://josh-project.dev/~/ui/browse?repo=josh.git&path=&filter=%3A%2Fdocs&rev=HEAD"><img src="https://img.shields.io/badge/try_it-josh--project.dev-black"/></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should also update to the latest UI version because as-is it's a bit underwhelming (and it's not obvious that it's not just a subfolder but a real git repo)

@LMG LMG enabled auto-merge (rebase) March 16, 2023 13:02
@LMG LMG merged commit 6b87f44 into master Mar 16, 2023
@LMG LMG deleted the vlad/docs branch March 16, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMG LMG LMG approved these changes

@christian-schilling christian-schilling Awaiting requested review from christian-schilling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-ivanov-name @LMG