[feat:] Added Config Command to Kitops CLI #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Singh <[email protected]>
Signed-off-by: Akash Singh <[email protected]>
|
@amisevsk Could you please review this PR and suggest upon how we can improve it? |
Signed-off-by: Akash Singh <[email protected]>
amisevsk
reviewed
Oct 10, 2024
Signed-off-by: Akash Singh <[email protected]>
|
@amisevsk Your requested changes have been made :D |
Signed-off-by: Akash <[email protected]>
amisevsk
reviewed
Oct 15, 2024
This commit refactors the code related to loading and saving the configuration file. It introduces a new function `ConfigFilePath` in the `consts.go` file to generate the path for the configuration file based on the `configHome` directory. The `LoadConfig` function now returns the default configuration if the file doesn't exist, and the `SaveConfig` function creates the directory before saving the file. These changes improve the reliability and maintainability of the configuration handling. Fixes jozu-ai#419
|
@amisevsk Your requested changes have been made! |
|
Can you add the license header for |
|
@gorkem license header has been added! |
gorkem
requested changes
Oct 21, 2024
There was a problem hiding this comment.
The code that manually parses subcommands and arguments has logic errors that needs to be fixed. The code manually inspects args[0] to determine the subcommand, which is not the standard practice. It is better to Define each subcommand (set, get, list, reset) as separate Cobra commands.
Co-authored-by: Gorkem Ercan <[email protected]>
|
@gorkem Your requested changes have been made, could you kindly review? |
gorkem
requested changes
Oct 24, 2024
amisevsk
reviewed
Nov 1, 2024
…onsistent logging
|
@amisevsk Your requested changes have been made! |
Closed
This was
linked to
issues
Nov 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the new
configcommand for the KitOps CLI. It allows users to manage the configuration of CLI settings more easily. With this command, users can set, get, list, and reset configuration values for persistent options like storage paths, credentials, logging levels, and other preferences.Key additions:
Config command: Introduced the
configcommand with four subcommands:set: Allows users to set configuration values.get: Retrieves the value of a specified configuration key.list: Lists all current configuration options and their values.reset: Resets all configurations back to default values.Persistent root flags: The root command now uses configuration settings from the
config.jsonfile for default values like--log-level,--progress, and--verbose, while still allowing overrides via command-line arguments.Linked Issues
Closes issue #419