Skip to content

Commit

Permalink
Properly store deleted puzzle group collapse state.
Browse files Browse the repository at this point in the history
As best as I can tell, this was a typo. Regular puzzle groups have their
state stored as long as there is no active search query. This makes
sense - as commit 2e09393 notes, it
would cause confusion when searching if we paid attention to collapse
state when showing search results. However, the deleted group behaves
the _opposite_ way - the state is _only_ persisted during searching. I
can't imagine why persisting the state in this case would be desirable,
but not during the no-search case. So this change makes everything
consistent.

See deathandmayhem#2278
  • Loading branch information
jpd236 committed Dec 21, 2024
1 parent 09dd7af commit 6b7b04c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion imports/client/components/PuzzleListPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ const PuzzleListView = ({
includeCount={false}
canUpdate={canUpdate}
suppressedTagIds={[]}
trackPersistentExpand={searchString !== ""}
trackPersistentExpand={searchString === ""}
/>
)}
</div>
Expand Down

0 comments on commit 6b7b04c

Please sign in to comment.