Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact endpoints and tests #45

Merged
merged 29 commits into from
Jul 1, 2019
Merged

Contact endpoints and tests #45

merged 29 commits into from
Jul 1, 2019

Conversation

rheinwerk-mp
Copy link
Contributor

This PR extends the contacts API.

  • It adds methods for two endpoints (merge and update_by_email).
  • Following Naming Conventions and Deprecation Policy #39 the naming conventions for the methods have been unified. The old methods raise a deprecation warning and call their respective new method. All methods in the file have been reordered, so related methods like update_by_email and update_by_id follow each other and all deprecated methods are moved to the end of the file.
  • Following Running tests not against the live HubSpot demo account #40 the tests have been rewritten as unit tests.

Also a small bugfix for hubspot3/base.py, where the json.loads wasn't wrapped by the try-except in case the data content is bytes.

rheinwerk-mp and others added 29 commits June 27, 2019 11:25
@rheinwerk-mp
Ensured consistent naming by renaming methods and marking former meth…
2fd8e69 
…ods as deprecated. Also changed docstrings to use imperative.
@rheinwerk-mp
Added two endpoints
1c47a3f
@rheinwerk-mp
Merge branch 'feature/contact_endpoints' into feature/INC-1791-2
9cd7b6d
@rheinwerk-mp
Ensured consistent naming by renaming methods and marking former meth…
1f5cb21 
…ods as deprecated
@W1ldPo1nter @rheinwerk-mp
Added a fixture for a mocked connection to simplify tests using mock …
7470902 
…requests
@rheinwerk-mp
Renamed parameters
0a8c75d
@rheinwerk-mp
Refactored to use the try-except in both cases, if data is bytes or i…
dc4c784 
…f data is string
@rheinwerk-mp
Removed return since the endpoint returns "SUCCESS" as string
a663470
@rheinwerk-mp
Made data optional and unfolded list for better assertion per argument
bc345fe
@rheinwerk-mp
Moved default_batch_properties for class attribute for better testabi…
a8b8224 
…lity
@rheinwerk-mp
Changed currents tests to using the mock client
d784567
@rheinwerk-mp
Added testing for passing the extra_properties as string or as list
babd344
@rheinwerk-mp
Used black to reformat files
46d7e28
@rheinwerk-mp
Reordered methods, moved deprecated to the end of the file
de59ae3
@rheinwerk-mp
Refactored tests for deprecated methods
ce5a570
@W1ldPo1nter @rheinwerk-mp
Let assert_has_request produce a better result for debugging
1be974b
@W1ldPo1nter @rheinwerk-mp
Applied black styling
602d920
@W1ldPo1nter @rheinwerk-mp
Allow parameters with multiple values in assert_query_parameters_in_r…
56d9a57 
…equest
@rheinwerk-mp
Set response_body as OrderedDict, added json.dumps() for `set_respo…
e0123de 
…nse` method call
@W1ldPo1nter
Merge pull request #5 from jpetrucciani/master
c0a4b24 
Upstream changes
@rheinwerk-mp
Merged assert_has_request and assert_query_parameters_in_request into…
2387e57 
… one check
@rheinwerk-mp
Refactored testing of the query parameters
7af47d4
@rheinwerk-mp
Merge branch 'master' into feature/INC-1791-2
a59a0e8 
# Conflicts:
#	hubspot3/test/conftest.py
@rheinwerk-mp
Adjusted test to new behavior of assert_has_request
ab2034d
@rheinwerk-mp
Corrected OrderedDict usage
7368b79
@rheinwerk-mp
Extended message string and fixed merge
e1ccfa9
@rheinwerk-mp
Removed OrderedDict usage
7293ff6
@rheinwerk-mp
Blacked files
85759bd
@W1ldPo1nter
Merge pull request #4 from rheinwerk-verlag/feature/INC-1791-2
b8e1c34 
Extend contacts API
@jpetrucciani
Copy link
Owner

Awesome - I'll get this reviewed and merged soon!

@jpetrucciani jpetrucciani merged commit f52da5a into jpetrucciani:master Jul 1, 2019
@jpetrucciani
Copy link
Owner

This is now merged, and it is live on pip as version 3.2.18!

Thanks again for your contributions! 😄

@W1ldPo1nter W1ldPo1nter deleted the feature/contact_endpoints branch July 2, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rheinwerk-mp @jpetrucciani @W1ldPo1nter