Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color prop not working for Link #4384

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Fix color prop not working for Link #4384

merged 4 commits into from
Nov 11, 2024

Conversation

joshwooding
Copy link
Contributor

Cherry picked from #4325

Fixes #4324

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 4b1540c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/core Patch
@salt-ds/countries Patch
@salt-ds/data-grid Patch
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 2:09pm

@joshwooding joshwooding marked this pull request as ready for review November 11, 2024 12:09
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 11, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 11, 2024
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 11, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 11, 2024
@joshwooding joshwooding changed the title Variant prop default to color Fix color prop not working for Link Nov 11, 2024
@joshwooding joshwooding merged commit b395246 into main Nov 11, 2024
15 of 16 checks passed
@joshwooding joshwooding deleted the fix-link-color branch November 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link color prop is overridden
4 participants