refactor: improve toClassName function readability and JSDoc completeness

[Ayoub-Mabrouk]

refactor: improve toClassName function readability and JSDoc completeness

• Replaced substr with slice for better readability and consistency.
• Updated JSDoc to include @param and @returns tags for clarity on function inputs and outputs.
• Simplified the conditional logic by using slice(-5) === 'Error' for a concise and clear check.

[wesleytodd]

While I am not a huge fan of PR's with changes like the code reformatting which do not have meaningful behavior changes (so maybe try to avoid those in the future) I think it is more readable, and the JSDoc updates are also good. Since this PR has been open for 5 days and has now two approvals I think we can merge.

[Ayoub-Mabrouk]

While I am not a huge fan of PR's with changes like the code reformatting which do not have meaningful behavior changes (so maybe try to avoid those in the future) I think it is more readable, and the JSDoc updates are also good. Since this PR has been open for 5 days and has now two approvals I think we can merge.

Thank you @wesleytodd for the feedback! This PR includes more than just formatting improvements: I replaced substr with slice (deprecated on MDN) and refactored the conditional to remove negation, following best practices from Google’s JavaScript Style Guide and Clean Code. These changes, along with clearer JSDoc, aim to improve maintainability.
Contributions that enhance readability and the long-term health of the project are incredibly valuable for everyone involved, especially for future contributors. I’ll keep your feedback in mind for future contributions. Thanks again for approving!

[wesleytodd]

This PR includes more than just formatting improvements

Yep 😄, and that stuff is why I merged it.

Contributions that enhance readability and the long-term health of the project are incredibly valuable for everyone involved

Happy to discuss this in general (maybe in our discussions repo?), but there are more details to discuss than just readability. In general since my involvement in the project we have not accepted readability PRs. They are highly subjective and often cause more problems than they solve. Very glad to see you are open to the feedback and look forward to more of your contributions!