Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NiftyPerforce - VS 2019 Compatibility #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgvincen
Copy link

@jgvincen jgvincen commented Oct 2, 2019

Added support for building/running Nifty Perforce with Visual Studio 2019.
Added partial support for loading the Nifty Perforce extension in the background.

Added support for building/running Nifty Perforce with Visual Studio 2019.
Added partial support for loading the Nifty Perforce extension in the background.
@jtilander
Copy link
Owner

Looks great. Terribly sorry though, my employer prevents me from doing any open source.

@jgvincen
Copy link
Author

jgvincen commented Oct 3, 2019

I understand, I wouldn't want to make trouble.
Are you allowed to approve/reject code changes which you didn't write?

@benh57
Copy link

benh57 commented Oct 16, 2019

Works4Me. Perhaps @belkiss could merge?

@belkiss
Copy link
Contributor

belkiss commented Oct 16, 2019

Works4Me. Perhaps @belkiss could merge?

Heya! I can't merge this here since I don't have permissions :)
My fork https://github.com/belkiss/niftyplugins has had support for vs2019 for a while now, but I didn't make the changes for async load, so I'll try and integrate those changes there!

Thanks for the heads-up :)

@akamboj
Copy link

akamboj commented Oct 21, 2019

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

@belkiss
Copy link
Contributor

belkiss commented Oct 22, 2019

I've integrated the changes, they work great! belkiss@3e27df8

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

I'll try and setup the CI so we can release vsix, I'll keep you posted :)

@jgvincen
Copy link
Author

Glad to hear that someone picked up my change.
So, I guess @belkiss's fork has become the unofficial new mainline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants