Handle form post response mode #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://openid.net/specs/oauth-v2-form-post-response-mode-1_0.html - Currently only implemented in GET - Add form_post.html for auto submitting the params
- Add response_mode handling to AuthorizeError cases so it returns expected response method - Since parse_qs returns each value as a list, select that item so context dict is always key: value instead of key: [value]
- The response should contain either query params or a fragment. - Choose the one that isn't empty and create the POST params dict from that
- Update test_settings to include the form_post template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #335
I implemented this in
AuthorizeView.postas well. Hopefully I interpreted that correctly! Thanks!