Skip to content

Commit

Permalink
Fix some Publish script issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Imperiopolis committed Jul 20, 2023
1 parent 99118db commit 6584524
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Publish
run: >-
gradlew clean publish
./gradlew clean publish
-PossrhUsername="${{ secrets.OSSRH_USERNAME }}"
-PossrhPassword="${{ secrets.OSSRH_PASSWORD }}"
-PsigningPassword="${{ secrets.ANDROID_SIGNING_PASSWORD }}"
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
- name: Publish
run: |
cp ../README.md .
sed -i '' 's/juicebox-sdk-wasm/juicebox-sdk/' package.json
sed -i 's/juicebox-sdk-wasm/juicebox-sdk/' package.json
npm publish
working-directory: javascript/juicebox-sdk
env:
Expand All @@ -89,6 +89,9 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: Publish
run: pod trunk push --verbose --allow-warnings
run: |
eval `ssh-agent -s`
ssh-add - <<< "${{ secrets.ACCESS_KEY }}"
pod trunk push --verbose --allow-warnings
env:
COCOAPODS_TRUNK_TOKEN: "${{ secrets.COCOAPODS_TRUNK_TOKEN }}"
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ preBuild {

def getVersionName() {
try {
return hasProperty('version') ? version : 'git describe --tags --exact-match'.execute().text.trim()
return hasProperty('versionString') ? versionString : 'git describe --tags --exact-match'.execute().text.trim()
} catch (Exception e) {
throw new GradleException("Git tag not found. Please make sure you have tagged your commit.")
}
Expand Down

0 comments on commit 6584524

Please sign in to comment.