Added support for GamePi20 #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
reviewed
Mar 3, 2021
| @@ -15,7 +15,7 @@ | |||
| #define DISPLAY_SET_CURSOR_Y 0x2B | |||
| #define DISPLAY_WRITE_PIXELS 0x2C | |||
|
|
|||
| #if defined(ST7789) || defined(ST7789VW) | |||
| #if (defined(ST7789) || defined(ST7789VW)) && !defined(WAVESHARE_GAMEPI20) | |||
There was a problem hiding this comment.
This #if won't be entered with the GamePi, and neither will the two #elifs below, so won't this cause the #error Unknown display controller! line be taken?
Can you change this to
#if defined(WAVESHARE_GAMEPI20)
#define DISPLAY_NATIVE_WIDTH 240
#define DISPLAY_NATIVE_HEIGHT 320
#elif defined(ST7789) || defined(ST7789VW)
....to follow the general flow of the size setup code here? (and drop the #define sizes in the changed block below?)
|
Great, very good work! Had that one question above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.