fix: add Cargo as a build dependency to charmcraft.yaml #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Nov 8, 2024
hpidcock
approved these changes
Nov 8, 2024
This required in order to build the binary wheel(s) required by the included COS libs.
manadart
force-pushed
the
3.5-charmcraft-cargo
branch
2 times, most recently
from
ec02c3b to
a0f5f36
Compare
Version 3 of charmcraft does not allow a run-on stanza that includes 24.04 with other versions, but 2 does. So we install this versions for our Github workflows.
manadart
force-pushed
the
3.5-charmcraft-cargo
branch
from
a0f5f36 to
55fc19d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Cargo as a dependency to charmcraft.yaml for building the charm.
It is required in order to build the binary wheel(s) required by the included COS libs.
In addition, we use the 2.x/stable version of charmcraft in workflows, so that we can include 24.04 in a list of run-on bases. Version 3 does not support this.