-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge 3.6 to main with charmcraft 3 #85
Draft
hpidcock
wants to merge
20
commits into
main
Choose a base branch
from
charmcraft3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
results in an error with the new version of Ops.
Uses BlockedStatus instead of ErrorStatus
Merge 3.3 into 3.4
Merge 3.4 into 3.5
feat: add 24.04 as a supported Ubuntu base
chore: merge 3.4 into 3.5
This required in order to build the binary wheel(s) required by the included COS libs.
fix: add Cargo as a build dependency
This required in order to build the binary wheel(s) required by the included COS libs.
Version 3 of charmcraft does not allow a run-on stanza that includes 24.04 with other versions, but 2 does. So we install this versions for our Github workflows.
fix: add Cargo as a build dependency to charmcraft.yaml
Testing on an old version was vestigial.
Not sure how we ended up with this list of architectures.
chore: merge 3.5 into 3.6
We can only currently build for one base, but we can remote build on launchpad and thus get builds for all supported arches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #84
Revisions 117, 118, 119 and 120 are based on this. Following the same patching @wallyworld did for 3.6.