-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs for RTD #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but it would be easier to review if the first PR just pulled in the spinx starter pack and the second PR added the actual docs. Also there seem to be a bunch of linting warnings.
/merge |
@tmihoc some of the new GitHub Actions are failing due to:
the markdown-lint action doesn't like the current
from https://github.com/juju/terraform-provider-juju/actions/runs/11911988799/job/33194654028?pr=631 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge PR... but looks like what we need.
name: Main Documentation Checks | ||
|
||
on: | ||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be made period, or disabled, similar to the one on main. See: juju/juju#18427
@@ -0,0 +1,19 @@ | |||
name: Periodic Style Checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be worth running this manually to check it works.
d941f33
to
557d781
Compare
Description
This PR creates a docs/docs-rtd directory with a Sphinx project and docs content from Discourse for a newly created RTD project.
The content for now mainly consists of a homepage, tutorial, and how-to guides.
The links to
juju
(i.e., juju/juju repo) concepts are for now pointing to juju,is. That should work, because any pages moved out of there will have redirects, so the links should be fine. The links toterraform-provider-juju
reference are for now to the Terraform Registry home of the provider.TODO: In a follow-up PR it would be good to use the docs/docs-rtd/reference directory to hold all tool reference materials. These are currently under docs/data-sources and docs/resources. When we move them to reference we should consider how that will affect the content on https://registry.terraform.io/providers/juju/juju/latest/docs . In principle, the Terraform Registry page should contain nothing more than autogenerated reference plus a link to the new terraform-provider-juju RTD project, which will contain the complete set of terraform-provider-juju docs, user docs as well as developer docs.
Fixes:
Type of change
Documentation.
Environment
Juju controller version:
Terraform version:
QA steps
Additional notes
JIRA card: JUJU-7097