This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Add image to radio widget #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benny0642
reviewed
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| choices[choiceIndex].box = [i.width, i.height]; | ||
| }; | ||
| choices[choiceIndex] = _.extend({}, choices[choiceIndex], { | ||
| content: "![](" + reader.result + ")", |
pytseng-junyi
commented
Jul 3, 2017
src/widgets/image.jsx
Outdated
| var reader = new FileReader(); | ||
| var that = this; | ||
| reader.onloadend = function() { | ||
| // console.log('RESULT', reader.result); |
pytseng-junyi
commented
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| var i = new Image(); | ||
| var that = this; | ||
| reader.readAsDataURL(file); | ||
| reader.onloadend = function() { |
pytseng-junyi
commented
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| i.src = reader.result; | ||
| i.onload = function(){ | ||
| choices[choiceIndex].box = [i.width, i.height]; | ||
| }; |
There was a problem hiding this comment.
這塊應該要留著，這裡釋放update box w h
pytseng-junyi
commented
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| } | ||
| }, | ||
|
|
||
| toggleUseBoxSize: function(choiceIndex) { |
There was a problem hiding this comment.
done 有warning, 有error,按checkbox會有can't read box[0] 因為box是undefined 但是不影響使用，
pytseng-junyi
commented
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| <BlurInput | ||
| type="number" | ||
| value={choice.box ? parseInt(choice.box[0]) : null} | ||
| onChange={value => { |
There was a problem hiding this comment.
不應該改，他是吃string，反而是把type = number拿掉 因為沒有用
pytseng-junyi
commented
Jul 3, 2017
src/widgets/radio.jsx
Outdated
| // so what we do here is to make a image file and set base64 part of the content as src | ||
| var resizeImage = new Image(); | ||
| resizeImage.src = choice.content.match(/(!\[\])\((.*)\)/)[2]; | ||
| resizeImage.onload = function() { |
There was a problem hiding this comment.
什麼時候開始讀resizeImage.src
onload 哪時
There was a problem hiding this comment.
object.onload 是load完才跑
FileReader.onloadend 是另外的 也是read完file才跑
pytseng-junyi
commented
Jul 17, 2017
| var choices = this.props.choices.slice(); | ||
| choices[choiceIndex] = _.extend({}, choices[choiceIndex], { | ||
| content: newContent | ||
| content: newWidget |
There was a problem hiding this comment.
onWidgetChange沒有用到，可以刪除
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.