Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declare dependency on packaging #109

Merged
merged 1 commit into from
Dec 18, 2024
Merged

declare dependency on packaging #109

merged 1 commit into from
Dec 18, 2024

Conversation

bollwyvl
Copy link
Contributor

Congrats on 0.11.0!

As discussed on #103, this PR adds a dependency on packaging, as it is unconditionally imported in logger.py.

We can ship it on conda-forge with the added dependency, or hold.

Links

@bollwyvl bollwyvl mentioned this pull request Dec 18, 2024
Merged
3 tasks
@bollwyvl bollwyvl closed this Dec 18, 2024
@bollwyvl bollwyvl reopened this Dec 18, 2024
@Carreau Carreau added dependencies Pull requests that update a dependency file maintenance labels Dec 18, 2024
@Carreau Carreau merged commit 21d4694 into jupyter:main Dec 18, 2024
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @Carreau