Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qodana CI checks #4

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add qodana CI checks #4

merged 2 commits into from
Dec 20, 2024

Conversation

qodana-cloud[bot]
Copy link
Contributor

@qodana-cloud qodana-cloud bot commented Dec 20, 2024

Adds qodana.yaml and GitHub workflow file that runs Qodana static analysis on each pull request.

@juryrigcoder juryrigcoder self-requested a review December 20, 2024 04:28
@juryrigcoder juryrigcoder self-assigned this Dec 20, 2024
@juryrigcoder juryrigcoder merged commit 5524a6a into main Dec 20, 2024
4 checks passed
@juryrigcoder juryrigcoder deleted the qodana-automation-1073796352 branch December 20, 2024 04:29
Copy link

Qodana for .NET

507 new problems were found

Inspection name Severity Problems
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 42
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 15
Namespace does not correspond to file location 🔶 Warning 14
Non-accessed field (private accessibility) 🔶 Warning 9
Redundant name qualifier 🔶 Warning 7
Non-nullable member is uninitialized. 🔶 Warning 4
Unresolved file references 🔶 Warning 4
Private field can be converted into local variable 🔶 Warning 4
Redundant 'object.ToString()' call 🔶 Warning 3
Async function without await expression 🔶 Warning 2
Possible null reference assignment. 🔶 Warning 2
Nullability of reference types in source type doesn't match target type. 🔶 Warning 2
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 2
Unused parameter (private accessibility) 🔶 Warning 2
Unused local variable 🔶 Warning 2
Dereference of a possibly null reference. 🔶 Warning 1
Collection content is never queried (private accessibility) 🔶 Warning 1
Collection is never updated (private accessibility) 🔶 Warning 1
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 1
'GC.SuppressFinalize' is invoked for type without destructor 🔶 Warning 1
Unresolved file in a link 🔶 Warning 1
Invalid XML documentation comment 🔶 Warning 1
'??' condition is never null according to nullable reference types' annotations 🔶 Warning 1
Possibly unintended linear search in set 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
Redundant using directive 🔶 Warning 1
Unassigned readonly field 🔶 Warning 1
Auto-property accessor is never used (private accessibility) 🔶 Warning 1
Type member is never used (non-private accessibility) ◽️ Notice 176
Invert 'if' statement to reduce nesting ◽️ Notice 29
Type is never used (non-private accessibility) ◽️ Notice 26
Convert constructor into primary constructor ◽️ Notice 14
Use collection expression syntax ◽️ Notice 14
Property can be made init-only (non-private accessibility) ◽️ Notice 13
Unused parameter (non-private accessibility) ◽️ Notice 12
Type member is never accessed via base type (non-private accessibility) ◽️ Notice 10
Class is never instantiated (non-private accessibility) ◽️ Notice 9
Auto-property can be made get-only (non-private accessibility) ◽️ Notice 7
Convert 'if' statement into 'switch' ◽️ Notice 7
Use explicit or implicit modifier definition for type members ◽️ Notice 6
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 6
Use preferred 'var' style (for built-in types) ◽️ Notice 6
Member can be made static (shared) (private accessibility) ◽️ Notice 5
Some values of the enum are not processed inside 'switch' statement and are handled via default section ◽️ Notice 5
Use preferred style of 'new' expression when created type is not evident ◽️ Notice 4
Convert local variable or field into constant (private accessibility) ◽️ Notice 4
Merge null/pattern/value checks into 'or'/'and' patterns ◽️ Notice 3
Redundant 'else' keyword ◽️ Notice 3
Dictionary lookup can be simplified with 'GetValueOrDefault' ◽️ Notice 2
Convert constructor into member initializers ◽️ Notice 2
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 2
Use preferred 'var' style (when type is simple) ◽️ Notice 2
Cast expression can be replaced with lambda return type ◽️ Notice 1
Replace 'switch' statement with 'switch' expression ◽️ Notice 1
Use compound assignment ◽️ Notice 1
Field can be made readonly (private accessibility) ◽️ Notice 1
Foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 1
Loop can be converted into LINQ-expression ◽️ Notice 1
Member can be made private (non-private accessibility) ◽️ Notice 1
Merge null/pattern checks into complex pattern ◽️ Notice 1
Redundant type declaration body ◽️ Notice 1
Use preferred 'var' style (elsewhere) ◽️ Notice 1
Use deconstruction ◽️ Notice 1
Use raw string ◽️ Notice 1
Use 'with' expression to copy record ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 16 dependencies

Third-party software list

This page lists the third-party software dependencies used in StoryblokSharp

Dependency Version Licenses
Microsoft.Extensions.Caching.Abstractions 9.0.0 MIT
Microsoft.Extensions.Caching.Memory 9.0.0 MIT
Microsoft.Extensions.Configuration.Abstractions 9.0.0 MIT
Microsoft.Extensions.Configuration.Binder 9.0.0 MIT
Microsoft.Extensions.Configuration 9.0.0 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 9.0.0 MIT
Microsoft.Extensions.DependencyInjection 9.0.0 MIT
Microsoft.Extensions.Diagnostics.Abstractions 9.0.0 MIT
Microsoft.Extensions.Diagnostics 9.0.0 MIT
Microsoft.Extensions.Http 9.0.0 MIT
Microsoft.Extensions.Logging.Abstractions 9.0.0 MIT
Microsoft.Extensions.Logging 9.0.0 MIT
Microsoft.Extensions.ObjectPool 9.0.0 MIT
Microsoft.Extensions.Options.ConfigurationExtensions 9.0.0 MIT
Microsoft.Extensions.Options 9.0.0 MIT
Microsoft.Extensions.Primitives 9.0.0 MIT
Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants