Merge pull request #452 from jvalue/bugfix/process-exit-spy-fix

Fixed `process.exit` not exiting tested method
jvalue · Sep 28, 2023 · 1da1fe3 · 1da1fe3
2 parents 0191f6b + 34945df
commit 1da1fe3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/apps/interpreter/src/examples-smoke-test.spec.ts b/apps/interpreter/src/examples-smoke-test.spec.ts
@@ -7,6 +7,7 @@ import * as path from 'path';
 import {
   clearBlockExecutorRegistry,
   clearConstraintExecutorRegistry,
+  processExitMockImplementation,
 } from '@jvalue/jayvee-execution/test';
 import {
   PostgresLoaderExecutorMock,
@@ -53,14 +54,14 @@ describe('jv example smoke tests', () => {
   beforeAll(() => {
     exitSpy = jest
       .spyOn(process, 'exit')
-      // eslint-disable-next-line @typescript-eslint/no-unused-vars
-      .mockImplementation((code?: number) => undefined as never);
+      .mockImplementation(processExitMockImplementation);
     httpExtractorMock = new HttpExtractorExecutorMock();
     postgresLoaderMock = new PostgresLoaderExecutorMock();
     sqliteLoaderMock = new SQLiteLoaderExecutorMock();
   });
 
   afterEach(() => {
+    exitSpy.mockClear();
     httpExtractorMock.restore();
     postgresLoaderMock.restore();
     sqliteLoaderMock.restore();

diff --git a/libs/execution/test/utils.ts b/libs/execution/test/utils.ts
@@ -28,6 +28,13 @@ export function clearConstraintExecutorRegistry() {
   constraintExecutorRegistry.clear();
 }
 
+export function processExitMockImplementation(code?: number) {
+  if (code === undefined || code === 0) {
+    return undefined as never;
+  }
+  throw new Error(`process.exit: ${code}`);
+}
+
 export function getTestExecutionContext(
   locator: AstNodeLocator,
   document: LangiumDocument<AstNode>,