Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIG-5270] - Reset commit timer every commit call #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eric-weaver
Copy link
Contributor

This adjusts the commit timer functionality to roughly ensure a commit occurs at least once every commit.time.s seconds since the last commit. Currently this timer functions as a wall clock commit every commit.time.s seconds regardless of how recently a commit was performed. In cases where the commit.time.s and backup.time.s wall clock times overlap such as commit every 300 seconds, backup every 600 seconds, we would previously perform commit -> backup + commit -> commit because the timers would overlap so the subsequent loop after backing up and committing would trip off the commit timer. This adjusts the timer to be less aggressive and only kick in when we haven't committed for roughly max commit.time.s seconds since we call commit() multiple places within the main build() loop.

This also adds some more logging around commit / backup start/stop as well as wrapping the commit time metric within the commit() function instead of just the timer based commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants