Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest stop bug #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix rest stop bug #74

wants to merge 2 commits into from

Conversation

fanhaouu
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. resolve scheduler not exit when call kubescheduler Stop
  2. resolve restmapper getAPIGroupResourcesres error when restConfig is nil

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

none

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@fanhaouu fanhaouu requested a review from likakuli March 14, 2023 11:19
@github-actions
Copy link

Please add a label from the following list: ['bug', 'documentation', 'duplicate', 'enhancement', 'good first issue', 'help wanted', 'invalid', 'question', 'size/L', 'size/M', 'size/S', 'wontfix']

@likakuli
Copy link
Contributor

waiting for kubernetes/kubernetes#116583 to merge

@likakuli
Copy link
Contributor

likakuli commented Jun 5, 2023

@fanhaouu can you rebase and resolve the conflict first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants