fix: clustervalidatemanager not effective bug

Signed-off-by: kaku <[email protected]>
k-cloud-labs · May 7, 2022 · 53b0be3 · 53b0be3
1 parent ec69e63
commit 53b0be3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/util/validatemanager/validatemanager.go b/util/validatemanager/validatemanager.go
@@ -57,9 +57,12 @@ func (m *validateManagerImpl) ApplyValidatePolicies(rawObj *unstructured.Unstruc
 					result, err := executeCue(rawObj, oldObj, rule.Cue)
 					if err != nil {
 						klog.ErrorS(err, "Failed to apply validate policy.", "validatepolicy", cvp.Name, "resource", klog.KObj(rawObj))
-						return result, err
+						return nil, err
 					}
 					klog.V(2).InfoS("Applied validate policy.", "validatepolicy", cvp.Name, "resource", klog.KObj(rawObj))
+					if !result.Valid {
+						return result, nil
+					}
 				}
 			}
 		}

diff --git a/util/validatemanager/validatemanager_test.go b/util/validatemanager/validatemanager_test.go
@@ -71,7 +71,7 @@ validate: {
 			oldObject: nil,
 			wantedErr: nil,
 			wantedResult: &ValidateResult{
-				Valid: true,
+				Valid: false,
 			},
 		},
 		{