Corrected namespaceSelector for network policy #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larwef
force-pushed
the
lars.wefald/hardening-correct-namespaceSelector
branch
from
94490e9 to
b4aa0b2
Compare
|
Discovered this doing a fresh install on a Raspberry Pi 4 and going through the hardening guide. When trying to acquiring a Let's Encrypt certificate through a Traefik DNS requests timed out. Not sure if v1.24 and Older is also affected by this. In case they should also be updated. |
brandond
approved these changes
Oct 11, 2024
|
Thanks for this fix - would you mind rebasing so that CI passes? |
|
Hi. I can force a new commit with the same changes. As far as i can see it's complaining about a dead link, which looks very much alive. |
larwef
force-pushed
the
lars.wefald/hardening-correct-namespaceSelector
branch
from
b4aa0b2 to
d91254b
Compare
|
Never mind. I got it now. Sorry, first time contributing. I will fix. |
Corrected namespaceSelector for intra-namespace network policy example. The label "name" does not exist on the namespace resource kube-system, but the label "kubernetes.io/metadata.name" does. Signed-off-by: Lars Wefald <[email protected]>
larwef
force-pushed
the
lars.wefald/hardening-correct-namespaceSelector
branch
from
d91254b to
c9a4fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected namespaceSelector for intra-namespace network policy example. The label "name" does not exist on the namespace resource kube-system, but the label "kubernetes.io/metadata.name" is present.