Skip to content

Commit

Permalink
Addressing comments
Browse files Browse the repository at this point in the history
Signed-off-by: Vitor Savian <[email protected]>
  • Loading branch information
vitorsavian committed Dec 2, 2024
1 parent 98f3c9b commit e5e2332
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ require (
github.com/google/cel-go v0.20.1 // indirect
github.com/google/gnostic-models v0.6.9-0.20230804172637-c7be7c783f49 // indirect
github.com/google/go-cmp v0.6.0 // indirect

github.com/google/gofuzz v1.2.0 // indirect
github.com/google/gopacket v1.1.19 // indirect
github.com/google/pprof v0.0.0-20240727154555-813a5fbdbec8 // indirect
Expand Down
6 changes: 5 additions & 1 deletion pkg/agent/containerd/containerd.go
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,13 @@ func prePullImages(ctx context.Context, client *containerd.Client, imageClient r
for scanner.Scan() {
name := strings.TrimSpace(scanner.Text())

if name == "" {
continue
}

// the options in the reference.ParseReference are for filtering only strings that cannot be seen as a possible image
if _, err := reference.ParseReference(name, reference.WeakValidation, reference.Insecure); err != nil {
logrus.Errorf("Unable to pull image %s: %v", name, err)
logrus.Errorf("Failed to parse image reference %q: %v", name, err)
continue
}

Expand Down

0 comments on commit e5e2332

Please sign in to comment.