Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.29] Add a guardrail for etcd-snapshot #11395

Open
wants to merge 1 commit into
base: release-1.29
Choose a base branch
from

Conversation

manuelbuil
Copy link
Contributor

Backport: #11314
Issue: #11391

FOR JANUARY RELEASE

@manuelbuil manuelbuil requested a review from a team as a code owner November 28, 2024 09:10
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.33%. Comparing base (7a4d8fc) to head (2db50f9).

Files with missing lines Patch % Lines
pkg/cluster/managed.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11395      +/-   ##
================================================
- Coverage         46.77%   42.33%   -4.45%     
================================================
  Files               179      179              
  Lines             18720    18730      +10     
================================================
- Hits               8756     7929     -827     
- Misses             8613     9602     +989     
+ Partials           1351     1199     -152     
Flag Coverage Δ
e2etests 34.46% <72.72%> (-7.74%) ⬇️
inttests 34.77% <72.72%> (-0.01%) ⬇️
unittests 13.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants