-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix agent tunnel address with dedicated supervisor port #11427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where rke2 tunnel was trying to connect to apiserver port instead of supervisor Signed-off-by: Brad Davidson <[email protected]>
dereknola
previously approved these changes
Dec 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11427 +/- ##
==========================================
- Coverage 47.66% 43.19% -4.48%
==========================================
Files 181 181
Lines 18797 18794 -3
==========================================
- Hits 8960 8118 -842
- Misses 8490 9477 +987
+ Partials 1347 1199 -148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
previously approved these changes
Dec 9, 2024
brandond
force-pushed
the
fix-supervisor-port
branch
from
December 9, 2024 18:40
7d7f90a
to
dbd7786
Compare
brandond
changed the title
Fix agent tunnel address on rke2
Fix agent tunnel address with dedicated supervisor port
Dec 9, 2024
brandond
force-pushed
the
fix-supervisor-port
branch
2 times, most recently
from
December 9, 2024 19:26
c41a335
to
af8abe9
Compare
dereknola
previously approved these changes
Dec 9, 2024
brandond
force-pushed
the
fix-supervisor-port
branch
from
December 9, 2024 20:44
af8abe9
to
29fe78d
Compare
dereknola
previously approved these changes
Dec 9, 2024
brandond
force-pushed
the
fix-supervisor-port
branch
from
December 9, 2024 21:28
29fe78d
to
7711797
Compare
vitorsavian
previously approved these changes
Dec 9, 2024
brandond
force-pushed
the
fix-supervisor-port
branch
2 times, most recently
from
December 9, 2024 22:22
c28b6ec
to
ff4cc0e
Compare
Add flags supervisor and apiserver ports and bind address so that we can add an e2e to cover supervisor and apiserver on separate ports, as used by rke2 Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-supervisor-port
branch
from
December 10, 2024 04:57
ff4cc0e
to
0cbfe94
Compare
OK, all done poking at this one. |
VestigeJ
approved these changes
Dec 10, 2024
vitorsavian
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix issue where rke2 tunnel was trying to connect to apiserver port instead of supervisor:
Note the incorrect port for the tunnel connection in RKE2 where the apiserver and supervisor are on different ports:
Types of Changes
bugfix
Verification
requires pull-through to rke2
Testing
Linked Issues
User-Facing Change
Further Comments