Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Remove experimental from embedded-registry flag #11446

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dereknola
Copy link
Member

Backport #11443

Proposed Changes

  • Move Spegel (embedded-registry) to GA status in CLI. Docs will be update according to note it went GA in December 2024 releases.

Types of Changes

CLI

Verification

k3s server --help shows embedded-registry no longer has the experimental tag

Testing

Linked Issues

TBD

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner December 9, 2024 18:31
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.29%. Comparing base (666b590) to head (ddc4a29).
Report is 2 commits behind head on release-1.29.

❗ There is a different number of reports uploaded between BASE (666b590) and HEAD (ddc4a29). Click for more details.

HEAD has 36 uploads less than BASE
Flag BASE (666b590) HEAD (ddc4a29)
inttests 33 11
unittests 3 1
e2etests 18 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11446      +/-   ##
================================================
- Coverage         46.72%   41.29%   -5.43%     
================================================
  Files               179      179              
  Lines             18720    18720              
================================================
- Hits               8746     7731    -1015     
- Misses             8617     9798    +1181     
+ Partials           1357     1191     -166     
Flag Coverage Δ
e2etests 32.42% <ø> (-9.78%) ⬇️
inttests 18.82% <ø> (-15.95%) ⬇️
unittests 13.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 20ea4f3 into k3s-io:release-1.29 Dec 10, 2024
30 checks passed
@dereknola dereknola deleted the spegel_ga_1.29 branch December 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants