Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate coredns version bumps with updatecli #11482

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RokibulHasan7
Copy link

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

#11392

User-Facing Change


Further Comments

@RokibulHasan7 RokibulHasan7 requested a review from a team as a code owner December 19, 2024 14:17
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.02%. Comparing base (83a3e85) to head (a28783b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (83a3e85) and HEAD (a28783b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (83a3e85) HEAD (a28783b)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11482      +/-   ##
==========================================
- Coverage   47.63%   39.02%   -8.62%     
==========================================
  Files         181      164      -17     
  Lines       18794    18204     -590     
==========================================
- Hits         8953     7104    -1849     
- Misses       8490     9908    +1418     
+ Partials     1351     1192     -159     
Flag Coverage Δ
e2etests 35.34% <ø> (-7.61%) ⬇️
inttests 34.90% <ø> (+16.17%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have a question about the new script though.

updatecli/scripts/run-make-generate.sh Outdated Show resolved Hide resolved
Signed-off-by: Rokibul Hasan <[email protected]>
@brandond
Copy link
Member

We're still in code freeze for the 1.32 release, we will resume merging things soon.

@cwayne18
Copy link
Member

Thank you very much for this! We'll get it merged as soon as we're out of code freeze, happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants