Run Subset of Docker tests in GitHub Actions #9698
Conversation
Build image with new input option Run most of the basic docker tests in E2E Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9698 +/- ##
==========================================
+ Coverage 43.59% 46.35% +2.76%
==========================================
Files 151 154 +3
Lines 13543 13595 +52
==========================================
+ Hits 5904 6302 +398
+ Misses 6420 6076 -344
+ Partials 1219 1217 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -30,10 +30,10 @@ env: | |||
| jobs: | |||
| build: | |||
| uses: ./.github/workflows/build-k3s.yaml | |||
| test: | |||
| itest: | |||
There was a problem hiding this comment.
what is the significance of the 'i'?
There was a problem hiding this comment.
short for integration?
jobs:
itest:
name: Integration TestsThe job key has no external significance, other than being able reference it as a dependency in the needs section of other jobs.
There was a problem hiding this comment.
Correct. This tag is necessary for the structure but ultimately irrelevant because there are no further jobs in this workflow. I just kept seeing test over and over in the workflows, and I want to make it something slightly more descriptive.
Proposed Changes
Note: This PR only reduced the drone load for amd64. For arm64/arm architectures the tests will remain as is, as GitHub Actions do not yet exist for those architectures.
Types of Changes
CI/Testing
Verification
Takes about 3 minutes off the Drone times... Not much, but every bit counts. Plus now the runners won't need pruning as much.
See https://github.com/dereknola/k3s/actions/runs/8193839495?pr=22, with the new matrices (as this PR won't run the new tests until commited to master for security reasons)
Linked Issues
#10421
User-Facing Change
Further Comments